Could not build a --release perseus app in beta.19 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is merged, will it be merged into the beta.19 or will it be part of a further release? |
|
You can't change existing releases with Cargo, but I'll release beta 20 asap. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #259
I could not run all tests, lots of building for a long time that ended abruptly with an unknown command
rust-script. Hopefully the CI can give a better feedback on this than I could.Since HSR is a development feature (right?), I just "wrapped" the problematic if conditions inside the debug guard. Let me know if that was not the right solution.