Support anyhow::Error in state generation functions
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures:
|
|
Oh this is great, thank you so much! Those CI failures are normal at this point, don't worry about them. |
`anyhow::Error` cannot implement `std::error::Error` (see dtolnay/anyhow#136), which Perseus requires for errors returned from state generation functions. But Perseus immediately boxes the error, and `anyhow::Error` does support conversion into `Box<dyn std::error::Error>`. So if we make the conversion from `BlamedError` to `GenericBlamedError` more general, `BlamedError<anyhow::Error>` works. This change should be backwards-compatible because Rust has an impl `From<E> for Box<dyn Error + Send + Sync + 'a>`. That impl should match all error types previously accepted by Perseus, and is sufficient to still accept them after this change.
This makes `?` on an `anyhow::Error` work in a function returning `Result<S, BlamedError<anyhow::Error>>`.
|
Force-pushed to sign the commits (no content changes). |
arctic-hen7
changed the title
anyhow::Eror in state generation functionsanyhow::Error in state generation functions
arctic-hen7
added a commit
that referenced
this pull request
Mar 22, 2023
Extends #264 for head, headers, build paths, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By generalizing the supported errors in state generation from types that directly implement
std::error::Errorto types that can be converted into a boxedstd::error::Error, we can makeanyhow::Errorwork.I first tried to support just
anyhow::Errorspecifically (in addition to the already-supported error types), but the compiler does not easily allow that: it thinksanyhow::Errormight implementstd::error::Errorin the future, so it will not let me implement things on both. Please make sure the broader support for error types this adds is reasonable (and that I am correct about this change being backwards-compatible) before merging.