Fix styling on Google Chrome #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The styling on chrome is a bit broken because it does not support `display: ruby`. Also according to https://stackoverflow.com/questions/42897783/what-is-displayruby, it seems like `display: ruby` is being misused in this case.
arctic-hen7
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Much appreciated! I remember going through each display option in the Firefox DevTools to see if any worked, and I seemed to recall the only one being ruby, but it seems inline-flex works too! The only issue is the slightly larger size of the GitHub button now, but I can fix that very easily.
arctic-hen7
added a commit
that referenced
this pull request
Oct 8, 2021
… index page Follow-up from #54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styling on chrome is a bit broken because it does not support
display: ruby. Also according to https://stackoverflow.com/questions/42897783/what-is-displayruby, it seems likedisplay: rubyis being misused in this case.