Add feature transformation capabilities to FeatureView #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
protos/feast/core/FeatureView.proto
Outdated
| @@ -75,6 +74,9 @@ message FeatureViewSpec { | |||
|
|
|||
| // Whether these features should be served online or not | |||
| bool online = 8; | |||
|
|
|||
| // Transformation metadata for feature transformations | |||
| string transformation_metadata = 13; | |||
There was a problem hiding this comment.
Should use existing transformation proto
franciscojavierarceo
requested changes
Jul 3, 2024
| def write_to_offline_store( | ||
| self, | ||
| feature_view_name: str, | ||
| df: pd.DataFrame, |
There was a problem hiding this comment.
This should also support mode="python", which means it requires supporting Dict types.
| @@ -78,6 +124,7 @@ class FeatureView(BaseFeatureView): | |||
| tags: A dictionary of key-value pairs to store arbitrary metadata. | |||
| owner: The owner of the feature view, typically the email of the primary | |||
| maintainer. | |||
| transformation_metadata: Metadata for feature transformations, including the transformation function. | |||
There was a problem hiding this comment.
should just use "transformation" like OnDemandFeatureView
…ctions in FeatureView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature transformation capabilities have been added to the FeatureView class to allow for on-demand transformations during materialization, similar to OnDemandFeatureView. This update also includes the necessary documentation changes.
This Devin run was requested by Francisco Javier.