Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parsing spreads in function call returns #285

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

egorpavlikhin
Copy link
Contributor

@egorpavlikhin egorpavlikhin commented Oct 20, 2023

Function return spreading

Description

Similarly to #251 spreading function return values inside of clsx call or similar fails with TypeError: Cannot read properties of undefined (reading 'type')

This is a simple fix to simply ignore those nodes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I added a test that matches my minimal reproduction. It fails without the introduced change.

Test Configuration:

  • OS + version: e.g. macOS Mojave
  • NPM version: ...
  • Node version: ...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@egorpavlikhin
Copy link
Contributor Author

@francoismassart any chance this could be merged?

@egorpavlikhin
Copy link
Contributor Author

@francoismassart

@francoismassart francoismassart merged commit 01bd10c into francoismassart:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants