Skip to content

Commit

Permalink
xfrm: fix rcu_read_unlock usage in xfrm_local_error
Browse files Browse the repository at this point in the history
In the xfrm_local_error, rcu_read_unlock should be called when afinfo
is not NULL. because xfrm_state_get_afinfo calls rcu_read_unlock
if afinfo is NULL.

Fixes: af5d27c ("xfrm: remove xfrm_state_put_afinfo")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
  • Loading branch information
TaeheeYoo authored and klassert committed Mar 16, 2018
1 parent 51d4740 commit 46c0ef6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions net/xfrm/xfrm_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,9 @@ void xfrm_local_error(struct sk_buff *skb, int mtu)
return;

afinfo = xfrm_state_get_afinfo(proto);
if (afinfo)
if (afinfo) {
afinfo->local_error(skb, mtu);
rcu_read_unlock();
rcu_read_unlock();
}
}
EXPORT_SYMBOL_GPL(xfrm_local_error);

0 comments on commit 46c0ef6

Please sign in to comment.