scsi: aacraid: Fix double-free on probe failure

[ Upstream commit 919ddf8 ]

aac_probe_one() calls hardware-specific init functions through the
aac_driver_ident::init pointer, all of which eventually call down to
aac_init_adapter().

If aac_init_adapter() fails after allocating memory for aac_dev::queues,
it frees the memory but does not clear that member.

After the hardware-specific init function returns an error,
aac_probe_one() goes down an error path that frees the memory pointed to
by aac_dev::queues, resulting.in a double-free.

Reported-by: Michael Gordon <m.gordon.zelenoborsky@gmail.com>
Link: https://bugs.debian.org/1075855
Fixes: 8e0c5eb ("[SCSI] aacraid: Newer adapter communication iterface support")
Signed-off-by: Ben Hutchings <benh@debian.org>
Link: https://lore.kernel.org/r/ZsZvfqlQMveoL5KQ@decadent.org.uk
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

drivers/scsi/aacraid/comminit.c

@@ -642,13 +642,15 @@ struct aac_dev *aac_init_adapter(struct aac_dev *dev)
 
  if (aac_comm_init(dev)<0){
  kfree(dev->queues);
+ dev->queues = NULL;
  return NULL;
  }
  /*
  * Initialize the list of fibs
  */
  if (aac_fib_setup(dev) < 0) {
  kfree(dev->queues);
+ dev->queues = NULL;
  return NULL;
  }