Improve failure output when comparing different pointers #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogpeppe
reviewed
Mar 22, 2022
checker.go
Outdated
| @@ -100,6 +100,18 @@ func (c *equalsChecker) Check(got interface{}, args []interface{}, note func(key | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if reflect.ValueOf(got).Kind() == reflect.Ptr && reflect.ValueOf(want).Kind() == reflect.Ptr && Format(got) == Format(want) { | |||
There was a problem hiding this comment.
Hmm, this isn't quite right when a custom formatter is used. I'm not sure what the right solution is there though.
Perhaps the answer is to move the logic into the printer, so it never prints as "same as" when the pointer values are the same, but instead prints something like <same content as "foo" but with different pointer value> or something?
WDYT?
frankban
force-pushed
the
different-pointers-same-format
branch
from
69b013a to
b54892e
Compare
frankban
force-pushed
the
different-pointers-same-format
branch
from
b54892e to
ed9fd1f
Compare
rogpeppe
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133