Support incremental annotation processing

[stephanenicolas]

Gradle 4.7 provides support for incremental annotation processing.
https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing

It would be nice to see icepick supporting it. The change is not that big as IcePick is an isolating AP, and even simpler as it doesn't handle inheritance.

[stephanenicolas]

@frankiesardo, is this project still maintained ?

[frankiesardo]

Hi @stephanenicolas I am still maintaining it in terms of bug fixing but I'm not that interested in adding new features.

[stephanenicolas]

@frankiesardo I understand that maintaining an old project is quite difficult sometimes, especially when you have moved on. Though, this feature is important to the Android community. Currently when you use any annotation processor (AP), gradle will do a clean build instead of an incremental build.

The new system requires all APs to comply to the incremental system to get an incremental build. And it's not a big change for most APs. If we can't make the change within IcePick, android users will have either to stop using it or to fork it. Can we submit a PR and you see if you wanna take it or not ? Or can we be added as contributors ? We don't really like clojure but we can get motivated for a PR or 2 ;)

[frankiesardo]

I'm willing to accept PRs. If it was about changing the resulting code I would be happy to do it but I can't spend time re-learning how Gradle evolved in the past years, it's out of my game now. I wish you a nice experience trying your skills with Clojure ;)

…

On Sat, 7 Apr 2018, 17:12 Stéphane Nicolas, ***@***.***> wrote: @frankiesardo <https://github.com/frankiesardo> I understand that maintaining an old project is quite difficult sometimes, especially when you have moved on. Though, this feature is important to the Android community. Currently when you use any annotation processor (AP), gradle will do a clean build instead of an incremental build. The new system requires all APs to comply to the incremental system to get an incremental build. And it's not a big change for most APs. If we can't make the change within IcePick, android users will have either to stop using it or to fork it. Can we submit a PR and you see if you wanna take it or not ? Or can we be added as contributors ? We don't really like clojure but we can get motivated for a PR or 2 ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABaH0WYh5bqCLBmtbqHArcfmfhRVNvcpks5tmOVZgaJpZM4S6SGt> .

[tprochazka]

It is not new feature it is the total blocker of using this library in the future projects.
At least please not close this Issue, maybe somebody will do pull request for it.
It is a quite important thing.

[frankiesardo]

I can reopen the issue in case somebody would like to pick it up. If it is a total blocker then it's the responsibility of the Gradle team since they've broken a perfectly working project. It shouldn't be a burden of the project maintainer to continuously update their projects.

[tprochazka]

It will still work, but it will significantly slow down the building, so for small projects, it is OK.
It is already implemented here
JakeWharton/butterknife#1230

[tprochazka]

Or maybe would be enough if support will be added here if it is a fork under active development.
https://github.com/evernote/android-state/issues/48
We will see.

[vRallev]

I've created a PR for Evernote/android-state#49

[vRallev]

https://github.com/evernote/android-state/ supports incremental annotation processing now.

[stephanenicolas]

We have switched to android-state. Thanks @vRallev for suggesting it. We really appreciate that it's in java and is already incremental.

Thx @frankiesardo for have created Icepick. It has really been very useful for us. Nice work !
May I encourage you to advertise using android-state and slowly prepare for freezing Icepick ?