Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to the remote-reader Android app:
Listener mode
The app now supports Listener mode as VICC supports.
accept()
for a client to connect (accept is timeouted to 1s and repeats with checking for cancellation)I find especially useful that it a smartcard app can open card connection multiple times without need to re-tap card to the phone. I can then run all integration tests with my card tapped to the phone without touching anything.
With original approach when app connects to the VPCD, the card has to be tapped each time VPCD connects.
We are using remote-reader without VPCD, the VPCD endpoint is added as another card connector to our application. Thus separate invocations require more taps.
This PR is a draft, if you want me to change something before merge, hit me up (assuming you are interested in the merge).
Thanks
May be interesting: I am using this with my personal project https://github.com/ph4r05/remote-card, it contains GlobalPlatformPro wrapper with software-enabled support for VICC (so no vpcd driver install is required). It is possible to manage applets via this GP wrapper over Android remote-reader.