Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Credential Store: Better error parsing? #133

Closed
guruz opened this issue Feb 1, 2019 · 2 comments
Closed

Windows Credential Store: Better error parsing? #133

guruz opened this issue Feb 1, 2019 · 2 comments

Comments

@guruz
Copy link
Contributor

guruz commented Feb 1, 2019

https://github.com/frankosterfeld/qtkeychain/blob/master/keychain_win.cpp#L63
https://docs.microsoft.com/en-us/windows/desktop/api/wincred/nf-wincred-credwritew#return-value

This might be something for @ckamm to do
@ckamm
Copy link
Contributor

ckamm commented Feb 3, 2019

This issue was created because an unknown error was observed in the CredWrite() call in an ownCloud Client ticket: owncloud/client#6776 (comment)

ckamm added a commit to ckamm/qtkeychain that referenced this issue Feb 4, 2019
@ckamm
Windows: Improve CredWrite() error handling
22236d6 
For frankosterfeld#133
@ckamm ckamm mentioned this issue Feb 4, 2019
Merged
ckamm added a commit to ckamm/qtkeychain that referenced this issue Feb 4, 2019
@ckamm
Windows: Improve CredWrite() error handling
f28490b 
For frankosterfeld#133
@frankosterfeld
Copy link
Owner

This seems fixed with the referenced patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frankosterfeld @ckamm @guruz