Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Setup chdir patch earlier #1421

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Jan 24, 2023

What: Setup monkey patching before any other bench code decides to chdir
Why: Since cache clearing wasn't setup earlier, caches weren't invalidated properly

Before

image

After

image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@gavindsouza gavindsouza changed the title fix: Setup chdir patch earlier fix(cli): Setup chdir patch earlier Jan 24, 2023
@gavindsouza gavindsouza merged commit bcc90c8 into frappe:develop Jan 24, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant