New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render legend after update, fixes #329 #330

Merged

scmmishra merged 2 commits into frappe:master from helge79:master

Mar 10, 2021

Contributor

helge79 commented Mar 8, 2021 •

edited

Loading

Explanation About What Code Achieves:

Fixes Legend on aggregate charts is not updated on full update #329 by calling renderLegend() after updating data

Steps To Test:

add an aggregate chart
call a full update via chart.update(data)
legend is updated

TODOs:

None

helge79 added 2 commits

March 8, 2021 14:07


          fix missing semicolon

4a9048f


          render legend after updating data

7f26c18

scmmishra approved these changes

View reviewed changes

scmmishra merged commit 85d7e60 into frappe:master

Contributor

scmmishra commented Mar 10, 2021

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet