Fix unnecessary notification API reloads for all users #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Emit WebSocket event only to the intended recipient instead of broadcasting - Improves performance by reducing unnecessary API calls and WebSocket traffic
|
@shariquerik In a large-scale production environment with over 15 active users, assigning multiple users at once becomes highly challenging. Each assignment triggers a notification call for every user, leading to a significant number of API requests per user. As a result, the total server load multiplies based on the number of assignments and users, potentially causing performance issues. This has actually happened with our client. So please fix ASAP |
shariquerik
approved these changes
Feb 20, 2025
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #594 where every user received a WebSocket event for all CRM notifications, causing unnecessary API reloads. Now, the event is emitted only for the intended recipient, reducing server load and improving efficiency.
Changes Made:
Updated
frappe.publish_realtime("crm_notification")to send the event only to the relevant user.Before (Inefficient, Broadcasts to All Users)
After (Optimized, Sends Only to Intended User)