feat: Add integration to shiprocket, delhivery, aramex, envia, shippo #50
Conversation
There was a problem hiding this comment.
Regarding the Shipping Provider doctype: when you want to contribute new features, it's a bad idea to change the architecture at the same time. Please stick to the existing architecture. I'm sure there are pros and cons to both. But I think there is not a good reason to change or use two different architectures at the same time.
|
Hi @barredterra , The existing way is creating new single doctypes for each of the providers. We will end up creating 5 new single doctypes for this. Also, when there are multiple companies on the same site, when two different companies have to use the same shipping provider with two different accounts (and so their credentials), the existing way isn't supporting it. That is limiting. We should consider moving LetmeShip and Send Cloud to the Shipping Provider in a different PR with a patch to migrate their data. What do you suggest? |
|
It is a very established practice that every integration gets its own settings doctype. (except when all use the same protocol, e.g. social login). Here, every shipping provider is different, as indicated by the many conditional fields and individual interfaces. Trying to fit them all into the same DocType isn't helpful and breaks with the existing architecture. You get one overly complex DocType instead of many simple ones. Regarding multi-company support, the individual provider settings could be a list with one entry per company. |
As a part of this PR, I am introducing a new doctype called Shipping Provider to refactor the existing design and introducing the following integration.
The existing ones such as letmeship, sendcloud is not affected by this refactoring.
This PR also changes how the shipping providers are configured. As ERPNext can have multiple companies in it, we need to configure multiple shipping accounts of the same shipping provider.