Skip to content

Commit

Permalink
fix(ux): don't update qty blindly (backport #38608) (#38639)
Browse files Browse the repository at this point in the history
fix(ux): don't update qty blindly

(cherry picked from commit 0156339)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
  • Loading branch information
mergify[bot] and s-aga-r authored Dec 8, 2023
1 parent c70e6f2 commit 0b2e2a2
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion erpnext/public/js/controllers/transaction.js
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
item.pricing_rules = ''
return this.frm.call({
method: "erpnext.stock.get_item_details.get_item_details",
child: item,
args: {
doc: me.frm.doc,
args: {
Expand Down Expand Up @@ -520,6 +519,19 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
callback: function(r) {
if(!r.exc) {
frappe.run_serially([
() => {
var child = locals[cdt][cdn];
var std_field_list = ["doctype"]
.concat(frappe.model.std_fields_list)
.concat(frappe.model.child_table_field_list);

for (var key in r.message) {
if (std_field_list.indexOf(key) === -1) {
if (key === "qty" && child[key]) continue;
child[key] = r.message[key];
}
}
},
() => {
var d = locals[cdt][cdn];
me.add_taxes_from_item_tax_template(d.item_tax_rate);
Expand Down

0 comments on commit 0b2e2a2

Please sign in to comment.