Merge pull request #38280 from frappe/mergify/bp/version-15-hotfix/pr…

…-38257

refactor: optmize outstanding amount query (backport #38257)

erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py

@@ -1171,6 +1171,7 @@ def test_rounding_of_unallocated_amount(self):
 		# Should not raise frappe.exceptions.ValidationError: Payment Entry has been modified after you pulled it. Please pull it again.
 		pr.reconcile()
 
+
 def make_customer(customer_name, currency=None):
 	if not frappe.db.exists("Customer", customer_name):
 		customer = frappe.new_doc("Customer")

erpnext/accounts/utils.py

@@ -1826,6 +1826,28 @@ def query_for_outstanding(self):
 					Table("outstanding").amount_in_account_currency >= self.max_outstanding
 				)
 
+		if self.limit and self.get_invoices:
+			outstanding_vouchers = (
+				qb.from_(ple)
+				.select(
+					ple.against_voucher_no.as_("voucher_no"),
+					Sum(ple.amount_in_account_currency).as_("amount_in_account_currency"),
+				)
+				.where(ple.delinked == 0)
+				.where(Criterion.all(filter_on_against_voucher_no))
+				.where(Criterion.all(self.common_filter))
+				.groupby(ple.against_voucher_type, ple.against_voucher_no, ple.party_type, ple.party)
+				.orderby(ple.posting_date, ple.voucher_no)
+				.having(qb.Field("amount_in_account_currency") > 0)
+				.limit(self.limit)
+				.run()
+			)
+			if outstanding_vouchers:
+				filter_on_voucher_no.append(ple.voucher_no.isin([x[0] for x in outstanding_vouchers]))
+				filter_on_against_voucher_no.append(
+					ple.against_voucher_no.isin([x[0] for x in outstanding_vouchers])
+				)
+
 		# build query for voucher amount
 		query_voucher_amount = (
 			qb.from_(ple)

erpnext/selling/doctype/customer/customer.py

@@ -663,7 +663,7 @@ def make_contact(args, is_primary_contact=1):
 				"company_name": args.get(party_name_key),
 			}
 		)
-		
+
 	contact = frappe.get_doc(values)
 
 	if args.get("email_id"):