Skip to content

Commit

Permalink
fix: typo's and parameter changes
Browse files Browse the repository at this point in the history
(cherry picked from commit 0ec1759)
  • Loading branch information
ruthra-kumar authored and mergify[bot] committed Jan 23, 2024
1 parent ecd3650 commit 41c074d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def get_jv_entries(self):
conditions.append(jea[dimension] == self.get(dimension))

if self.payment_name:
conditions.append(je.name.like(f"%%{self.payent_name}%%"))
conditions.append(je.name.like(f"%%{self.payment_name}%%"))

if self.get("cost_center"):
conditions.append(jea.cost_center == self.cost_center)
Expand Down Expand Up @@ -659,7 +659,7 @@ def get_journal_filter_conditions(self):
conditions.append(je.total_debit.gte(self.minimum_payment_amount))

if self.maximum_payment_amount:
conditions.append(je.total_debit.lte(self.maximumb_payment_amount))
conditions.append(je.total_debit.lte(self.maximum_payment_amount))

return conditions

Expand Down Expand Up @@ -747,6 +747,7 @@ def reconcile_dr_cr_note(dr_cr_notes, company):
inv.against_voucher,
None,
inv.cost_center,
frappe._dict(),
)


Expand Down
2 changes: 2 additions & 0 deletions erpnext/accounts/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1998,6 +1998,8 @@ def create_gain_loss_journal(
cost_center,
dimensions,
) -> str:
# TODO: pass dimensions to Journal

journal_entry = frappe.new_doc("Journal Entry")
journal_entry.voucher_type = "Exchange Gain Or Loss"
journal_entry.company = company
Expand Down

0 comments on commit 41c074d

Please sign in to comment.