Skip to content

Commit

Permalink
fix: handle gle for standalone credit and debit notes
Browse files Browse the repository at this point in the history
(cherry picked from commit 98a8288)
  • Loading branch information
GursheenK authored and mergify[bot] committed Nov 9, 2023
1 parent 22e58e0 commit 6e463b1
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions erpnext/accounts/doctype/payment_entry/payment_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -1072,24 +1072,27 @@ def add_party_gl_entries(self, gl_entries):
against_voucher_type = d.reference_doctype
against_voucher = d.reference_name

reverse_dr_or_cr = 0
reverse_dr_or_cr, standalone_note = 0, 0
if d.reference_doctype in ["Sales Invoice", "Purchase Invoice"]:
is_return = frappe.db.get_value(d.reference_doctype, d.reference_name, "is_return")
is_return, return_against = frappe.db.get_value(
d.reference_doctype, d.reference_name, ["is_return", "return_against"]
)
payable_party_types = get_party_types_from_account_type("Payable")
receivable_party_types = get_party_types_from_account_type("Receivable")
if is_return and self.party_type in receivable_party_types and self.payment_type == "Pay":
if is_return and self.party_type in receivable_party_types and (self.payment_type == "Pay"):
reverse_dr_or_cr = 1
elif is_return and self.party_type in payable_party_types and self.payment_type == "Receive":
elif (
is_return and self.party_type in payable_party_types and (self.payment_type == "Receive")
):
reverse_dr_or_cr = 1

if is_return and not return_against and not reverse_dr_or_cr:
dr_or_cr = "debit" if dr_or_cr == "credit" else "credit"

gle.update(
{
dr_or_cr: abs(allocated_amount_in_company_currency)
if reverse_dr_or_cr
else allocated_amount_in_company_currency,
dr_or_cr + "_in_account_currency": abs(d.allocated_amount)
if reverse_dr_or_cr
else d.allocated_amount,
dr_or_cr: abs(allocated_amount_in_company_currency),
dr_or_cr + "_in_account_currency": abs(d.allocated_amount),
"against_voucher_type": against_voucher_type,
"against_voucher": against_voucher,
"cost_center": cost_center,
Expand Down

0 comments on commit 6e463b1

Please sign in to comment.