-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove non-maintained Tax Detail report and missing workspace links #34192
fix: remove non-maintained Tax Detail report and missing workspace links #34192
Conversation
23cc448
to
fdfb351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove the report from here:
erpnext/erpnext/accounts/test/test_reports.py
Lines 33 to 36 in c3d4556
( | |
"Tax Detail", | |
{"mode": "run", "report_name": "Tax Detail"}, | |
), |
Not sure about backporting to v14... might there be people using this report in production?
fdfb351
to
3d0dc2b
Compare
Done
If they found it and managed to figure out how to use it. I doubt it. My module has a copy called |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34192 +/- ##
===========================================
- Coverage 63.88% 63.78% -0.10%
===========================================
Files 810 809 -1
Lines 59535 59334 -201
===========================================
- Hits 38032 37848 -184
+ Misses 21503 21486 -17 |
Removing contributed Tax Detail report because:
Also, whilst removing from the workspace, some Saudi Arabia (KSA) components have been removed
version-14-hotfix