Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove non-maintained Tax Detail report and missing workspace links #34192

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

casesolved-co-uk
Copy link

@casesolved-co-uk casesolved-co-uk commented Feb 23, 2023

Removing contributed Tax Detail report because:

Also, whilst removing from the workspace, some Saudi Arabia (KSA) components have been removed

version-14-hotfix

Copy link
Collaborator

@barredterra barredterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the report from here:

(
"Tax Detail",
{"mode": "run", "report_name": "Tax Detail"},
),

Not sure about backporting to v14... might there be people using this report in production?

@casesolved-co-uk
Copy link
Author

Please also remove the report from here:

Done

Not sure about backporting to v14... might there be people using this report in production?

If they found it and managed to figure out how to use it. I doubt it. My module has a copy called Tax Ledger that my customers use

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #34192 (58ae93c) into develop (ca10e2b) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34192      +/-   ##
===========================================
- Coverage    63.88%   63.78%   -0.10%     
===========================================
  Files          810      809       -1     
  Lines        59535    59334     -201     
===========================================
- Hits         38032    37848     -184     
+ Misses       21503    21486      -17     

see 1 file with indirect coverage changes

@barredterra barredterra added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Mar 18, 2023
@deepeshgarg007 deepeshgarg007 merged commit d8e73b6 into frappe:develop Mar 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants