-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Record Advance Payment as a liability #35609
Merged
deepeshgarg007
merged 34 commits into
frappe:develop
from
GursheenK:#34282-Record-advance-payment-as-a-liability
Jul 1, 2023
Merged
feat: Record Advance Payment as a liability #35609
deepeshgarg007
merged 34 commits into
frappe:develop
from
GursheenK:#34282-Record-advance-payment-as-a-liability
Jul 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to let user record advance payments as liability instead of a negative asset. Issue frappe#34282
Add Sales and Purchase Invoice Tests to check if GL entries and Outstanding Amount are generated correctly when advance entries are recorded as liability. Few changes to return value of added column in Payment Entry References.
deepeshgarg007
requested changes
Jun 9, 2023
e380d74
to
5e9821d
Compare
…pe#34282-Record-advance-payment-as-a-liability
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35609 +/- ##
===========================================
+ Coverage 64.15% 64.20% +0.05%
===========================================
Files 785 785
Lines 60485 60613 +128
===========================================
+ Hits 38803 38918 +115
- Misses 21682 21695 +13
|
finesoftke
pushed a commit
to finesoftke/erpnext
that referenced
this pull request
Aug 5, 2023
…vance-payment-as-a-liability feat: Record Advance Payment as a liability
|
5 tasks
ruthra-kumar
pushed a commit
that referenced
this pull request
Nov 22, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Nov 22, 2023
fix: partial cancel of gle and ple (backport #35609)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
# [14.50.0](v14.49.0...v14.50.0) (2023-11-24) ### Bug Fixes * don't depreciate non-depreciable assets on scrapping [v14] ([#38294](#38294)) ([5261aba](5261aba)) * partial cancel of gle and ple (backport [#35609](#35609)) ([80bc235](80bc235)) * patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38263](#38263)) ([756f08b](756f08b)) * Supplier `Primary Contact` (backport [#38268](#38268)) ([#38285](#38285)) ([f170cb9](f170cb9)) ### Features * add Bank Transaction to connections in Journal and Payment Entry ([#38297](#38297)) ([06c6da5](06c6da5)) ### Performance Improvements * optimize total_purchase_cost update ([a88d322](a88d322))
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current flow allows the user to record -
The Book Advance Payments in Separate Party Account feature introduces the option to use separate accounts for recording these Advance Payments. The option can be selected from the Company Doctype > Advance Payments Section
When selected, the user needs to provide the Default Advances Received Account and the Default Advances Paid Account in the Company master.


Default Advance Accounts can be set for a Customer/Customer Group/Supplier/ Supplier Group with respect to multiple companies from the Accounting Tab > Default Accounts Table
Example
A Payment Entry for receiving
₹1000
from a customer is submitted. The General Ledger Entries created for the same will use the Liability Account instead of the Receivable Account since it is an Advance Payment.Suppose a Sales Invoice with a total of
₹500
is created for the same customer and the Advance Payments are fetched and allocated using the Get Advances Received button. In such a case, when the Sales Invoice is submitted, the General Ledger for the Payment Entry will reflect the following changes.Since the total allocated amount to the Sales Invoice is
₹500
, the same has been debited from the Liability Account. The Liability Account will then hold the remaining₹500
as an Advance Payment.no-docs
Issue #34282