Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typeerror on TDS payable monthly report #37707

Merged

Conversation

ruthra-kumar
Copy link
Member

Screenshot 2023-10-26 at 8 37 47 PM

@ruthra-kumar ruthra-kumar changed the title fix: typerror on TDS payable monthly report fix: typeerror on TDS payable monthly report Oct 26, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #37707 (dc5d2c7) into develop (514d543) will decrease coverage by 0.02%.
Report is 65 commits behind head on develop.
The diff coverage is 87.41%.

@@             Coverage Diff             @@
##           develop   #37707      +/-   ##
===========================================
- Coverage    67.34%   67.32%   -0.02%     
===========================================
  Files          757      757              
  Lines        60098    60147      +49     
===========================================
+ Hits         40472    40496      +24     
- Misses       19626    19651      +25     
Files Coverage Δ
erpnext/accounts/general_ledger.py 90.55% <ø> (ø)
...tax_withholding_details/tax_withholding_details.py 79.45% <100.00%> (ø)
...g/doctype/supplier_scorecard/supplier_scorecard.py 55.97% <ø> (ø)
erpnext/manufacturing/doctype/bom/bom.py 78.49% <100.00%> (ø)
erpnext/setup/doctype/company/company.py 74.21% <ø> (ø)
erpnext/stock/get_item_details.py 83.06% <ø> (ø)
erpnext/stock/stock_ledger.py 84.53% <100.00%> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 84.29% <93.33%> (ø)
erpnext/controllers/stock_controller.py 82.20% <92.30%> (+0.05%) ⬆️
erpnext/setup/doctype/employee/employee.py 57.76% <0.00%> (ø)
... and 5 more

... and 9 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit e33fd45 into frappe:develop Oct 27, 2023
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant