Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crm): ensure primary address and contact follows customer setting #37710

Conversation

blaggacao
Copy link
Collaborator

Resuscitation of #37316

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #37710 (669f272) into develop (8d9f391) will increase coverage by 0.00%.
Report is 3 commits behind head on develop.
The diff coverage is 83.33%.

❗ Current head 669f272 differs from pull request most recent head f337bf5. Consider uploading reports for the commit f337bf5 to get more accurate results

@@           Coverage Diff            @@
##           develop   #37710   +/-   ##
========================================
  Coverage    67.39%   67.39%           
========================================
  Files          757      757           
  Lines        60379    60391   +12     
========================================
+ Hits         40692    40702   +10     
- Misses       19687    19689    +2     
Files Coverage Δ
erpnext/crm/doctype/lead/lead.py 68.72% <87.50%> (+0.68%) ⬆️
erpnext/selling/doctype/customer/customer.py 75.81% <75.00%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

Copy link

stale bot commented Nov 10, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 10, 2023
@stale stale bot removed the inactive label Nov 11, 2023
@deepeshgarg007 deepeshgarg007 merged commit a74e1f1 into frappe:develop Nov 11, 2023
11 of 12 checks passed
@blaggacao blaggacao deleted the fix/primary-contact-and-address-buisness-flow branch November 11, 2023 15:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants