Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ignore cancelled GLE's while looking for currency of existing entries #37720

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Oct 27, 2023

Ignore cancelled GLE's while looking for party gle currency

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #37720 (8d9b90f) into develop (514d543) will decrease coverage by 0.02%.
Report is 69 commits behind head on develop.
The diff coverage is 87.58%.

@@             Coverage Diff             @@
##           develop   #37720      +/-   ##
===========================================
- Coverage    67.34%   67.32%   -0.02%     
===========================================
  Files          757      757              
  Lines        60098    60146      +48     
===========================================
+ Hits         40472    40495      +23     
- Misses       19626    19651      +25     
Files Coverage Δ
erpnext/accounts/general_ledger.py 90.55% <ø> (ø)
erpnext/accounts/party.py 81.02% <100.00%> (+0.04%) ⬆️
...g/doctype/supplier_scorecard/supplier_scorecard.py 55.97% <ø> (ø)
erpnext/manufacturing/doctype/bom/bom.py 78.49% <100.00%> (ø)
erpnext/setup/doctype/company/company.py 74.21% <ø> (ø)
erpnext/stock/get_item_details.py 83.06% <ø> (ø)
erpnext/stock/stock_ledger.py 84.53% <100.00%> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 84.29% <93.33%> (ø)
erpnext/controllers/stock_controller.py 82.20% <92.30%> (+0.05%) ⬆️
erpnext/setup/doctype/employee/employee.py 57.76% <0.00%> (ø)
... and 5 more

... and 11 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit d2fdda8 into frappe:develop Oct 30, 2023
14 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Oct 30, 2023
ruthra-kumar added a commit that referenced this pull request Oct 30, 2023
…-37720

refactor: ignore cancelled GLE's while looking for currency of existing entries (backport #37720)
ruthra-kumar added a commit that referenced this pull request Oct 30, 2023
…-37720

refactor: ignore cancelled GLE's while looking for currency of existing entries (backport #37720)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant