fix: remove voucher type and no for Item and Warehouse based reposting #37849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rohitwaghchaure
commented
Nov 2, 2023
rohitwaghchaure
commented
- Remove voucher type and voucher no from the Repost Item Valuation if the reposting is based on "Item and Warehouse"
- Enable the Item based reposting default for the new sites
rohitwaghchaure
requested review from
deepeshgarg007 and
s-aga-r
as code owners
rohitwaghchaure
force-pushed
the
fixed-remove-voucher_type_no
branch
from
cee1b9a to
0104897
Compare
rohitwaghchaure
added
backport version-14-hotfix
rohitwaghchaure
added a commit
that referenced
this pull request
Nov 2, 2023
…-37849 fix: remove voucher type and no for Item and Warehouse based reposting (backport #37849)
mergify bot
added a commit
that referenced
this pull request
Nov 6, 2023
…g (backport #37849) (#37850) * fix: remove voucher type and no for Item and Warehouse based reposting (cherry picked from commit 0104897) * chore: fix test cases --------- Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> (cherry picked from commit e19cade) # Conflicts: # erpnext/stock/doctype/repost_item_valuation/test_repost_item_valuation.py # erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py # erpnext/stock/doctype/stock_reposting_settings/stock_reposting_settings.json
rohitwaghchaure
added a commit
that referenced
this pull request
Nov 7, 2023
…g (backport #37849) (backport #37850) (#37938) * fix: remove voucher type and no for Item and Warehouse based reposting (backport #37849) (#37850) * fix: remove voucher type and no for Item and Warehouse based reposting (cherry picked from commit 0104897) * chore: fix test cases --------- Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com> (cherry picked from commit e19cade) # Conflicts: # erpnext/stock/doctype/repost_item_valuation/test_repost_item_valuation.py # erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py # erpnext/stock/doctype/stock_reposting_settings/stock_reposting_settings.json * chore: fix conflicts * chore: fix conflicts * chore: fix conflicts * fix: conflicts --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
## [13.54.10](v13.54.9...v13.54.10) (2023-11-08) ### Bug Fixes * add missing disbursement account in update_old_loans patch ([37b1a0e](37b1a0e)) * bump pygithub requirement to handle conflict ([#37800](#37800)) ([13d5eec](13d5eec)) * e-invoice jwt verification error ([#37818](#37818)) ([8f4ded6](8f4ded6)) * permission error while creating Supplier Quotation from Portal (backport [#37864](#37864)) ([#37872](#37872)) ([6952f0f](6952f0f)) * Quality Inspection Parameter migration - DuplicateEntryError due to case sensitivity (backport [#37499](#37499)) ([#37918](#37918)) ([4789eca](4789eca)) * remove voucher type and no for Item and Warehouse based reposting (backport [#37849](#37849)) (backport [#37850](#37850)) ([#37938](#37938)) ([8cb0f69](8cb0f69))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
# [14.47.0](v14.46.7...v14.47.0) (2023-11-08) ### Bug Fixes * `TypeError` in PR for non-stock item ([ef4471f](ef4471f)) * add missing disbursement account in update_old_loans patch ([ad64065](ad64065)) * add translation wrapper (backport [#37911](#37911)) ([#37946](#37946)) ([c53d281](c53d281)) * don't reset rate if greater than zero in standalone debit note (backport [#37935](#37935)) ([#37940](#37940)) ([64658fc](64658fc)) * fetch asset received but not billed account only when needed ([7df4009](7df4009)) * gov compliance for tax withholding report ([#37590](#37590)) ([273cc35](273cc35)) * In-Transit Warehouse company filter (backport [#37796](#37796)) ([#37797](#37797)) ([0b1da08](0b1da08)) * link between parent and child procedure (backport [#37903](#37903)) ([#37943](#37943)) ([24da29a](24da29a)) * list index out of range ([#37880](#37880)) ([05fed9e](05fed9e)) * make `Material Request Item` required if `Material Request` is set in PO (backport [#37928](#37928)) ([#37936](#37936)) ([c870120](c870120)) * permission error while creating Supplier Quotation from Portal (backport [#37864](#37864)) ([#37870](#37870)) ([1a3dae0](1a3dae0)) * **plaid:** Do not sync pending transactions ([ffdc11b](ffdc11b)) * POS change amount gl entry with no amount ([#37799](#37799)) ([5e1a89b](5e1a89b)) * Quality Inspection Parameter migration - DuplicateEntryError due to case sensitivity (backport [#37499](#37499)) ([#37916](#37916)) ([eb3630b](eb3630b)) * remove voucher type and no for Item and Warehouse based reposting (backport [#37849](#37849)) ([#37850](#37850)) ([e19cade](e19cade)) * standard submit perm in repost ledger for editable invoices (backport [#37826](#37826)) ([#37854](#37854)) ([69b569d](69b569d)) * status for over delivery or billing ([d8e7430](d8e7430)) * type error on new payment entry ([38184f7](38184f7)) * typo in AR report ([3d72ec7](3d72ec7)) * validate so item with qtn ([4a225b0](4a225b0)) ### Features * reserved production plan sub assembly items (backport [#37884](#37884)) ([#37926](#37926)) ([4de97a4](4de97a4)) * settings page for repost ([09cde5d](09cde5d)) * **Stock Balance:** add filters from route (backport [#37836](#37836)) ([#37839](#37839)) ([e8a706a](e8a706a)) ### Performance Improvements * Add index to supplier invoice field (backport [#37861](#37861)) ([#37862](#37862)) ([2c93f81](2c93f81)) * index return against for purchase invoice (backport [#37881](#37881)) ([#37882](#37882)) ([fed25fa](fed25fa))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.