Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 'group only by voucher' flag in AR/AP report #37869

Merged

Conversation

ruthra-kumar
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #37869 (0eea53c) into develop (ca69845) will increase coverage by 0.01%.
Report is 117 commits behind head on develop.
The diff coverage is 69.28%.

❗ Current head 0eea53c differs from pull request most recent head 23beb46. Consider uploading reports for the commit 23beb46 to get more accurate results

@@             Coverage Diff             @@
##           develop   #37869      +/-   ##
===========================================
+ Coverage    67.33%   67.34%   +0.01%     
===========================================
  Files          757      755       -2     
  Lines        60142    60153      +11     
===========================================
+ Hits         40496    40512      +16     
+ Misses       19646    19641       -5     
Files Coverage Δ
...ounts/doctype/bank_transaction/bank_transaction.py 69.71% <ø> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 84.27% <ø> (ø)
erpnext/accounts/party.py 81.02% <100.00%> (ø)
...tax_withholding_details/tax_withholding_details.py 79.87% <100.00%> (+0.42%) ⬆️
erpnext/accounts/utils.py 73.12% <100.00%> (ø)
...xt/buying/doctype/purchase_order/purchase_order.py 78.99% <ø> (ø)
erpnext/controllers/stock_controller.py 81.60% <ø> (-0.60%) ⬇️
...egrations/doctype/plaid_settings/plaid_settings.py 45.30% <100.00%> (ø)
...nufacturing/doctype/blanket_order/blanket_order.py 89.39% <ø> (ø)
...pnext/stock/doctype/delivery_trip/delivery_trip.py 62.08% <100.00%> (ø)
... and 13 more

... and 14 files with indirect coverage changes

@ruthra-kumar ruthra-kumar force-pushed the reconcile_only_on_voucher branch from 0eea53c to 23beb46 Compare November 3, 2023 06:17
@ruthra-kumar ruthra-kumar merged commit a9372c4 into frappe:develop Nov 3, 2023
10 of 11 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 3, 2023
…-37869

refactor: 'group only by voucher' flag in AR/AP report (backport #37869)
ruthra-kumar added a commit that referenced this pull request Nov 3, 2023
…-37869

refactor: 'group only by voucher' flag in AR/AP report (backport #37869)
@ruthra-kumar
Copy link
Member Author

ruthra-kumar commented Nov 6, 2023

patch release for v14 in #37929

ruthra-kumar added a commit that referenced this pull request Nov 6, 2023
refactor: 'group only by voucher' flag in AR/AP report (backport #37869) (backport #37873)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant