Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: expand repost to Expense Claim and make it configurable #37954

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

ruthra-kumar
Copy link
Member

Repost Accounting Ledger Settings has been added to allow configuring individual doctypes for Repost. Repost Accounting Ledger has been expanded to support Expense Claim.

Screenshot 2023-11-07 at 11 21 39 AM

@ruthra-kumar ruthra-kumar changed the title Expense claim repost refactor: expand repost to Expense Claim and make it configurable Nov 7, 2023
@ruthra-kumar ruthra-kumar force-pushed the expense_claim_repost branch 2 times, most recently from b150130 to 6c4c178 Compare November 7, 2023 06:05
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #37954 (10b9570) into develop (8fbd4ce) will increase coverage by 0.03%.
Report is 37 commits behind head on develop.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop   #37954      +/-   ##
===========================================
+ Coverage    67.37%   67.41%   +0.03%     
===========================================
  Files          755      757       +2     
  Lines        60202    60327     +125     
===========================================
+ Hits         40562    40668     +106     
- Misses       19640    19659      +19     
Files Coverage Δ
...dger_settings/repost_accounting_ledger_settings.py 100.00% <100.00%> (ø)
...ctype/repost_allowed_types/repost_allowed_types.py 100.00% <100.00%> (ø)
erpnext/assets/doctype/asset/asset.py 80.37% <ø> (ø)
...preciation_schedule/asset_depreciation_schedule.py 89.42% <100.00%> (ø)
erpnext/stock/doctype/bin/bin.py 96.20% <ø> (-0.68%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 81.22% <100.00%> (+0.07%) ⬆️
...stock_reservation_entry/stock_reservation_entry.py 83.01% <100.00%> (+0.92%) ⬆️
...ounts/doctype/bank_transaction/auto_match_party.py 91.83% <83.33%> (+0.08%) ⬆️
...post_accounting_ledger/repost_accounting_ledger.py 94.39% <45.45%> (-5.61%) ⬇️
erpnext/stock/stock_ledger.py 82.66% <63.04%> (-0.88%) ⬇️

... and 9 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 6210b24 into frappe:develop Nov 7, 2023
13 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 7, 2023
…-37954

refactor: expand repost to `Expense Claim` and make it configurable (backport #37954)
ruthra-kumar added a commit that referenced this pull request Nov 7, 2023
…-37954

refactor: expand repost to `Expense Claim` and make it configurable (backport #37954)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant