Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pick serial nos from selected batch only #37988

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Nov 8, 2023

Internal Ref: 4132

Issue: In Stock Reconciliation, the system selects all the available Serial Nos from the Warehouse. Which causes a difference in Current Qty and Current Serial No. Ideally, it should pick the Serial Nos for the selected Batch.

image

Steps to Reproduce:

  • Create a Serial Batch Item.
  • Inward Stock in two Batches.
  • Create a Stock Reconciliation, select any Batch. Check the Current Qty and Current Serial No.

Before:

image

After:

image

Fixes: #37012

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Nov 8, 2023
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Nov 9, 2023
@s-aga-r s-aga-r marked this pull request as ready for review November 9, 2023 07:00
@s-aga-r s-aga-r merged commit db29180 into frappe:version-14-hotfix Nov 9, 2023
8 of 9 checks passed
@s-aga-r
Copy link
Contributor Author

s-aga-r commented Nov 9, 2023

@Mergifyio backport version-14

Copy link
Contributor

mergify bot commented Nov 9, 2023

backport version-14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 9, 2023
* fix: pick current serial nos from selected batch only

* test: add test case for current qty and current serial nos

(cherry picked from commit db29180)
s-aga-r added a commit that referenced this pull request Nov 9, 2023
fix: pick serial nos from selected batch only (#37988)

* fix: pick current serial nos from selected batch only

* test: add test case for current qty and current serial nos

(cherry picked from commit db29180)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Nov 9, 2023
## [14.47.2](v14.47.1...v14.47.2) (2023-11-09)

### Bug Fixes

* pick serial nos from selected batch only (backport [#37988](#37988)) ([#38011](#38011)) ([0405aae](0405aae))
frappe-pr-bot pushed a commit that referenced this pull request Nov 14, 2023
# [14.48.0](v14.47.4...v14.48.0) (2023-11-14)

### Bug Fixes

* asset depreciation ledger (backport [#37991](#37991)) ([#37992](#37992)) ([043dc1b](043dc1b))
* close `Credit Limit Crossed` dialog (backport [#38052](#38052)) ([#38058](#38058)) ([6979c3e](6979c3e))
* COA Importer app related issues ([#37238](#37238)) ([57ce73d](57ce73d))
* german translations of Accounts Settings ([b75aae9](b75aae9))
* indentation issue in the Production Plan Summary report (backport [#38019](#38019)) ([#38068](#38068)) ([c552884](c552884))
* make adjustment entry using stock reconciliation (backport [#37995](#37995)) ([#38008](#38008)) ([984703c](984703c))
* make item field read-only in batch (backport [#38010](#38010)) ([#38033](#38033)) ([424ebd1](424ebd1))
* minor change added to test_case ([6b34568](6b34568))
* minor issue ([0eab723](0eab723))
* new logic for handling revaluation journals ([9c0d80c](9c0d80c))
* pick serial nos from selected batch only ([#37988](#37988)) ([db29180](db29180))
* sales order not assigned to territory orders ([#37905](#37905)) ([#38024](#38024)) ([620f4f2](620f4f2))
* Set right party name in bank transaction ([21b430a](21b430a))
* **translations:** suggestions from review ([4d2169e](4d2169e))
* Use `process.extract` to get the corresponding party doc name of the result ([b0a184e](b0a184e))

### Features

* **accounts_receivable:** test_case added for multi-select customer group ([cf0d936](cf0d936))
* multi-select customer group in AR Report ([935286f](935286f))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.48.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants