Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of exchange rate journals in AR/AP #38004

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Nov 9, 2023

New checkbox to tweak outstanding and outstanding_in_account_currency handling logic to better accomodate Exchange Rate Revaluation journals.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #38004 (1d8fcd6) into develop (922fffd) will increase coverage by 0.00%.
Report is 9 commits behind head on develop.
The diff coverage is 71.42%.

@@           Coverage Diff            @@
##           develop   #38004   +/-   ##
========================================
  Coverage    67.39%   67.39%           
========================================
  Files          757      757           
  Lines        60371    60379    +8     
========================================
+ Hits         40686    40693    +7     
- Misses       19685    19686    +1     
Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 89.83% <71.42%> (-0.27%) ⬇️

... and 2 files with indirect coverage changes

@ruthra-kumar ruthra-kumar force-pushed the ar_report_refactor_in_handling_gain_loss branch 2 times, most recently from 8c0a4f5 to c4b8201 Compare November 10, 2023 04:30
@ruthra-kumar ruthra-kumar changed the title refactor: handling of exchange rate journals in AR/AP fix: handling of exchange rate journals in AR/AP Nov 10, 2023
@ruthra-kumar ruthra-kumar force-pushed the ar_report_refactor_in_handling_gain_loss branch from c4b8201 to 1d8fcd6 Compare November 10, 2023 05:02
@ruthra-kumar ruthra-kumar merged commit 8d9f391 into frappe:develop Nov 10, 2023
13 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 10, 2023
…-38004

fix: handling of exchange rate journals in AR/AP (backport #38004)
ruthra-kumar added a commit that referenced this pull request Nov 10, 2023
…-38004

fix: handling of exchange rate journals in AR/AP (backport #38004)
@ruthra-kumar
Copy link
Member Author

@mergify backport version-14

Copy link
Contributor

mergify bot commented Nov 10, 2023

backport version-14

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Nov 10, 2023
fix: handling of exchange rate journals in AR/AP (backport #38004)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant