-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: supercharge Bulk actions #38038
Merged
ruthra-kumar
merged 16 commits into
frappe:develop
from
ruthra-kumar:refactor_bulk_transaction
Nov 16, 2023
Merged
refactor: supercharge Bulk actions #38038
ruthra-kumar
merged 16 commits into
frappe:develop
from
ruthra-kumar:refactor_bulk_transaction
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #38038 +/- ##
===========================================
- Coverage 67.39% 67.23% -0.16%
===========================================
Files 757 757
Lines 60371 60441 +70
===========================================
- Hits 40686 40637 -49
- Misses 19685 19804 +119
|
erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.js
Outdated
Show resolved
Hide resolved
erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.py
Show resolved
Hide resolved
ruthra-kumar
added a commit
that referenced
this pull request
Nov 16, 2023
…-38038 refactor: supercharge Bulk actions (backport #38038)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 20, 2023
…-38038 refactor: supercharge Bulk actions (backport #38038)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk Processing feature was poorly designed, due to which its performance deteriorates as more and more actions are taken in a single day. With the redesign, we've improved the normal processing speed significantly and removed the performance degradation completely.
Details:
Bulk Transaction Log
has been converted to a virtual doctype and has simple success and fail count, and UI button to retry for failed documents.Bulk Transaction Log Detail
has been converted from child to a normal doctype.update_logger
method, which updated the entireBulk Transaction Log
document for every document, which directly caused the poor performance, has been removed completely. It has been replaced withcreate_log
which is just a simple method to createBulk Transaction Log Detail
Performance
Compared to the
26.668 s
from the previous refactor, this6.74 s
is a 74% reduction in runtime for processing the same volume of documents.Demo
bulk_refactor.mp4
Internal Ref: 5034, 5626