Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch item_tax_template values if fields with fetch_from exisit #38284

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

vorasmit
Copy link
Collaborator

Existing behaviour

  • Function get_item_details fetches item tax template.
  • There are no existing fields with fetch_from in the item tax template
  • If a custom field is there with fetch_from in the item tax template, it's not fetched with item details

With this fix, it will support fetching custom fields (in item tax template) along with item details

Required for: resilient-tech/india-compliance#227

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #38284 (b206b05) into develop (627165d) will increase coverage by 0.00%.
Report is 9 commits behind head on develop.
The diff coverage is 75.86%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38284   +/-   ##
========================================
  Coverage    67.26%   67.27%           
========================================
  Files          757      757           
  Lines        60517    60550   +33     
========================================
+ Hits         40709    40734   +25     
- Misses       19808    19816    +8     
Files Coverage Δ
erpnext/accounts/utils.py 73.33% <100.00%> (+0.16%) ⬆️
erpnext/controllers/accounts_controller.py 84.85% <100.00%> (+<0.01%) ⬆️
erpnext/stock/get_item_details.py 83.11% <100.00%> (+0.08%) ⬆️
...e/payment_reconciliation/payment_reconciliation.py 91.94% <65.00%> (-1.94%) ⬇️

... and 2 files with indirect coverage changes

@vorasmit vorasmit force-pushed the fetch-item-tax-values branch from db49b00 to b206b05 Compare November 23, 2023 09:40
@deepeshgarg007 deepeshgarg007 merged commit 2989e36 into frappe:develop Nov 26, 2023
13 checks passed
@deepeshgarg007
Copy link
Member

@vorasmit let us know when to backport this

@vorasmit
Copy link
Collaborator Author

Thank you for reviewing this.

This is independent and can be backported. Looking for this in v14 and 15.

@vorasmit vorasmit deleted the fetch-item-tax-values branch November 26, 2023 13:15
deepeshgarg007 added a commit that referenced this pull request Dec 17, 2023
fix: fetch item_tax_template values if fields with fetch_from exisit (#38284)
deepeshgarg007 added a commit that referenced this pull request Dec 17, 2023
fix: fetch item_tax_template values if fields with fetch_from exisit (#38284)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests. stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants