fix: fetch exc rate of multi currency journals on reconciliation #38717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38717 +/- ##
===========================================
- Coverage 60.16% 60.07% -0.09%
===========================================
Files 759 759
Lines 69475 69549 +74
===========================================
- Hits 41800 41784 -16
- Misses 27675 27765 +90
|
ruthra-kumar
force-pushed
the
7101_payment_reconciiation_bug
branch
from
9919707 to
1b3ba25
Compare
ruthra-kumar
changed the title
ruthra-kumar
added
backport version-14-hotfix
This was referenced Dec 14, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Dec 14, 2023
…-38717 fix: fetch exc rate of multi currency journals on reconciliation (backport #38717)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 14, 2023
…-38717 fix: fetch exc rate of multi currency journals on reconciliation (backport #38717)
|
@mergify backport version-14 |
✅ Backports have been created
|
ruthra-kumar
added a commit
that referenced
this pull request
Dec 14, 2023
fix: fetch exc rate of multi currency journals on reconciliation (backport #38717)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In payment reconciliation tool, multi-currency journals incorrectly post Exc gain/loss journal, even if the journal and payment has the same exc rate.