fix: validation error on reconciling PE to Journals as Invoice #38766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the same exchange rate on Journal Entry and Payment Entry, reconcilition should not post exc gain/loss journal and should not throw validation error
github-actions
bot
added
accounts
needs-tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38766 +/- ##
========================================
Coverage 60.07% 60.08%
========================================
Files 759 759
Lines 69547 69555 +8
========================================
+ Hits 41780 41789 +9
+ Misses 27767 27766 -1
|
ruthra-kumar
added
backport version-14-hotfix
This was referenced Dec 15, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Dec 15, 2023
…-38766 fix: validation error on reconciling PE to Journals as Invoice (backport #38766)
ruthra-kumar
added a commit
that referenced
this pull request
Dec 15, 2023
…-38766 fix: validation error on reconciling PE to Journals as Invoice (backport #38766)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the same exchange rate on Journal Entry and Payment Entry, reconcilition should not post exc gain/loss journal and should not throw validation error.