Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset the incoming rate on changing of the warehouse #38909

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  1. Create a standalone credit note entry for warehouse A
  2. Based on previous stock ledger entry system will set the incoming rate
  3. Now create a new warehouse Warehouse B.
  4. Change the warehouse from Warehouse A to Warehouse B in the above standalone credit note
  5. System doesn't reset the incoming rate

@rohitwaghchaure rohitwaghchaure added backport develop instructs mergify to frontport PR to develop branch backport version-15-hotfix labels Dec 21, 2023
@rohitwaghchaure rohitwaghchaure merged commit 2770ca1 into frappe:version-14-hotfix Dec 21, 2023
6 checks passed
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
(cherry picked from commit 2770ca1)

# Conflicts:
#	erpnext/selling/sales_common.js
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
(cherry picked from commit 2770ca1)

# Conflicts:
#	erpnext/selling/sales_common.js
frappe-pr-bot pushed a commit that referenced this pull request Dec 27, 2023
# [14.57.0](v14.56.0...v14.57.0) (2023-12-27)

### Bug Fixes

* allow to set rate manually for service item in BOM ([#38880](#38880)) ([c2f692a](c2f692a))
* display all item rate stop messages ([226d0e0](226d0e0))
* do not reset the basic rate for the material receipt stock entry ([#38896](#38896)) ([98bfcc4](98bfcc4))
* first name error on customer creation ([#38927](#38927)) ([28f052d](28f052d))
* german translations for Lost Quotations ([#38435](#38435)) ([81b5e6c](81b5e6c))
* groups for current accounts in German CoAs ([39aa36e](39aa36e))
* incorrect price list in customer-wise item price report ([7577706](7577706))
* min order qty optional in production plan (backport [#38956](#38956)) ([#38957](#38957)) ([f6f2712](f6f2712))
* remove rows with zero consumed qty ([f2f4100](f2f4100))
* reposting not fixing valuation rate for sales return using movin… ([#38895](#38895)) ([3a668bb](3a668bb))
* reset the incoming rate on changing of the warehouse ([#38909](#38909)) ([2770ca1](2770ca1))
* skip jvs against bank accounts ([98198d3](98198d3))
* **test:** expect account currency when party account is specified. ([30cb218](30cb218))
* unset discount amount from coupon discounts ([87e8dd0](87e8dd0))
* use party account currency when party account is specified ([d9e0d55](d9e0d55))
* **ux:** make PR and PI Item rate field readonly based on `Maintain Same Rate` (backport [#38942](#38942)) ([#38943](#38943)) ([1eee203](1eee203))

### Features

* in_party_currency option for AR/AP reports ([3c717db](3c717db))
* total_asset_cost field (backport [#38879](#38879)) ([#38886](#38886)) ([8169c7d](8169c7d))

### Performance Improvements

* Drop unused/duplicate/sub-optimal indexes (backport [#38884](#38884)) ([#38912](#38912)) ([b254a72](b254a72))
* use estimated rows instead of actual rows (backport [#38830](#38830)) ([#38875](#38875)) ([4d1ccd9](4d1ccd9))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport develop instructs mergify to frontport PR to develop branch backport version-15-hotfix released selling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants