feat: In words in payment entry #39108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
force-pushed
the
in_words_pe
branch
from
20638a5 to
13aae34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #39108 +/- ##
========================================
Coverage 60.09% 60.10%
========================================
Files 757 757
Lines 70434 70447 +13
========================================
+ Hits 42326 42339 +13
Misses 28108 28108
|
|
Should this only apply to new payments or do we want to patch the existing ones as well? Functionality LGTM. |
|
@barredterra I think we should not update submitted or old payment entries. What is your opinion on this? Should we? |
deepeshgarg007
added a commit
that referenced
this pull request
Jan 26, 2024
…-39108 feat: In words in payment entry (#39108)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-docs