Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: projects website list visible for guests and all logged in customers #39153

Closed
wants to merge 0 commits into from

Conversation

0xD0M1M0
Copy link
Contributor

@0xD0M1M0 0xD0M1M0 commented Jan 4, 2024

fix: projects website list visible for guests and all logged in customers

see the issue for details

fixes issue #39009

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 4, 2024
@0xD0M1M0
Copy link
Contributor Author

0xD0M1M0 commented Jan 5, 2024

@s-aga-r I was wondering if you could kindly assist me with this PR. This is my first PR here and I have no idea why it fails and how to fix it.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (cdd5441) 60.08% compared to head (ca87341) 60.08%.
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #39153   +/-   ##
========================================
  Coverage    60.08%   60.08%           
========================================
  Files          761      761           
  Lines        70301    70304    +3     
========================================
+ Hits         42241    42243    +2     
- Misses       28060    28061    +1     
Files Coverage Δ
...ype/account/chart_of_accounts/chart_of_accounts.py 76.87% <100.00%> (ø)
erpnext/accounts/party.py 81.42% <100.00%> (ø)
erpnext/accounts/report/utils.py 78.36% <ø> (ø)
erpnext/setup/demo.py 94.24% <100.00%> (ø)
erpnext/setup/doctype/company/company.py 60.25% <100.00%> (ø)
...doctype/inventory_dimension/inventory_dimension.py 86.66% <100.00%> (ø)
...k/doctype/stock_ledger_entry/stock_ledger_entry.py 70.05% <100.00%> (+0.32%) ⬆️
erpnext/stock/serial_batch_bundle.py 86.58% <ø> (ø)
erpnext/stock/__init__.py 92.68% <0.00%> (ø)
erpnext/stock/utils.py 72.85% <50.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

@0xD0M1M0 0xD0M1M0 closed this Jan 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants