fix: Payment Terms Status for Sales Order report show all payment terms from orders (not only when there is a payment terms template) #39331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The report Payment Terms Status for Sales Order display payment schedule only for orders with Payment Terms template
It should display all payment terms schedule for order even if the is no template but also manually entered payments terms
Actually the filter
(so.payment_terms_template != "NULL")
is not correct, at least it have to be
(so.payment_terms_template.notnull())
If you really want this filter
Actually will compare NULL as a string :
tabSales Order.payment_terms_template <> "NULL"
as it should be :
NOT tabSales Order.payment_terms_template IS NULL
But any way, there is no need to filter incoming amount from orders with payment terms template, just payment term is enough. The payment Terms template is not use else where in the report
Note to reviewer, if this PR is accepted, could you please add github label backport to version-15 and version-14 ?