Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disallow bank transactions on different currencies #39336

Merged

Conversation

ruthra-kumar
Copy link
Member

Prevent Bank Transaction's on a different currency to the Bank Account currency.
Screenshot 2024-01-12 at 4 39 38 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 12, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e53931e) 60.04% compared to head (a27a4db) 60.07%.
Report is 71 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39336      +/-   ##
===========================================
+ Coverage    60.04%   60.07%   +0.03%     
===========================================
  Files          761      757       -4     
  Lines        70459    70418      -41     
===========================================
- Hits         42304    42303       -1     
+ Misses       28155    28115      -40     
Files Coverage Δ
...cturing/doctype/production_plan/production_plan.py 80.70% <100.00%> (-0.13%) ⬇️
...ounts/doctype/bank_transaction/bank_transaction.py 63.30% <87.50%> (+3.20%) ⬆️
erpnext/controllers/accounts_controller.py 85.11% <50.00%> (+0.01%) ⬆️

... and 18 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 6bb2d91 into frappe:develop Jan 15, 2024
13 checks passed
ruthra-kumar added a commit that referenced this pull request Jan 15, 2024
…-39336

refactor: disallow bank transactions on different currencies (backport #39336)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant