Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect active serial nos #39389

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Jan 15, 2024

Steps to Replicate the Issue

  • Create the Purchase Receipt on 10th Jan 2024 for the serial no item with 10 qty
  • Create the Stock Reconciliation on 12th Jan 2024 for the same serial no and change the qty from 10 to 5
  • Create the backdated Purchase Receipt on 9th Jan 2024 for the serial no item with 10 qty
  • After that check the Active Serial Nos count
  • You will notice that the active serial nos are 15 and not 5.

@github-actions github-actions bot added the stock label Jan 15, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-active-serial-nos branch 6 times, most recently from 4cb6be4 to 7c49429 Compare January 17, 2024 09:21
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-active-serial-nos branch from 7c49429 to 64cb115 Compare January 24, 2024 09:45
@rohitwaghchaure rohitwaghchaure merged commit 23199a3 into frappe:develop Jan 24, 2024
12 checks passed
rohitwaghchaure added a commit that referenced this pull request Jan 27, 2024
fix: incorrect active serial nos

(cherry picked from commit 64cb115)

Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jan 30, 2024
# [15.11.0](v15.10.8...v15.11.0) (2024-01-30)

### Bug Fixes

* AttributeError in company transaction deletion ([222005c](222005c))
* **Batch:** reload doc after splitting ([a97b8fd](a97b8fd))
* check page obj before adding menu ([0aa73e3](0aa73e3))
* default enable closing stock balance (backport [#39551](#39551)) ([#39554](#39554)) ([4853ab1](4853ab1))
* do not auto-populate item delivery date ([5cdc22a](5cdc22a))
* email list for auto reorder material request ([98c5653](98c5653))
* enqueue JV submission when more than 100 accounts ([07bcc24](07bcc24))
* fetch correct quantity and amount for grouped asset ([3bdd1e9](3bdd1e9))
* honour currency precision while fetching balance ([e0a3820](e0a3820))
* incorrect active serial nos (backport [#39389](#39389)) ([#39589](#39589)) ([7def475](7def475))
* incorrect amount in the material request item (backport [#39567](#39567)) ([#39569](#39569)) ([e0c35d6](e0c35d6))
* Item Tax template is not working for e-commerce ([2905db1](2905db1))
* make SO item code reqd ([171586d](171586d))
* not able to edit address through portal ([1f5dbeb](1f5dbeb))
* not able to save BOM (duplicate key error) (backport [#39620](#39620)) ([#39623](#39623)) ([53c7055](53c7055))
* not able to save subcontracting purchase receipt (old flow) (backport [#39590](#39590)) ([#39592](#39592)) ([63eef68](63eef68))
* not able to submit subcontracting pr (old flow) (backport [#39622](#39622)) ([#39625](#39625)) ([960443d](960443d))
* Payment Terms Status for Sales Order report should show all payment terms from order not only this comming from template ([b2e0d24](b2e0d24))
* perf issue while submitting stock entry (backport [#39634](#39634)) ([#39642](#39642)) ([d785c6c](d785c6c))
* prevent extra transfer against inter transfer transaction (backport [#39213](#39213)) ([#39596](#39596)) ([6d4ca6a](6d4ca6a))
* qtn tests using delivery date ([6b20a7e](6b20a7e))
* return doc obj after submit ([da33079](da33079))
* Serial No Ledger permission issue ([f9d1995](f9d1995))
* skip liability account for internal transfer ([e2d85c5](e2d85c5))
* type error on company doc ([a7d1368](a7d1368))

### Features

* In words in payment entry ([5df2f5d](5df2f5d))
* New financial views - Growth and margin views for P&L and balance sheet ([#39588](#39588)) ([a83f310](a83f310))
* Partly billed status in Purchase Receipt ([#39543](#39543)) ([e4230cf](e4230cf))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant