Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email list for auto reorder material request #39525

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

Auto Material Requests emails are being sent to users who don't have access to the respective Material Requests company.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ebc8230) 60.09% compared to head (764f342) 60.13%.
Report is 69 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39525      +/-   ##
===========================================
+ Coverage    60.09%   60.13%   +0.04%     
===========================================
  Files          757      757              
  Lines        70434    70621     +187     
===========================================
+ Hits         42325    42470     +145     
- Misses       28109    28151      +42     
Files Coverage Δ
...tax_withholding_details/tax_withholding_details.py 81.14% <90.00%> (ø)
erpnext/stock/reorder_item.py 74.45% <69.56%> (+1.11%) ⬆️

... and 17 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit a552df8 into frappe:develop Jan 24, 2024
15 checks passed
rohitwaghchaure added a commit that referenced this pull request Jan 24, 2024
…-39525

fix: email list for auto reorder material request (backport #39525)
rohitwaghchaure added a commit that referenced this pull request Jan 24, 2024
…-39525

fix: email list for auto reorder material request (backport #39525)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant