Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not delete batches implicitly #39548

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  1. Create automatically batch on submission of the purchase receipt
  2. Make delivery note against the respective batch
  3. Cancel the delivery note (don't delete)
  4. Try to cancel the Purchase Receipt (created at step 1)
  5. You will get an error that "Cannot delete or cancel because Batch is linked with Delivery Note"
image

Upon cancellation of the purchase receipt, the system attempts to delete the corresponding batches. However, as these batches are linked to other canceled documents, the system does not allow the user to cancel the purchase receipt. Ideally, the batches should not be deleted implicitly, and the user should manually delete them.

@rohitwaghchaure rohitwaghchaure force-pushed the fix-do-not-delete-batch-implicitly branch from 5f36300 to 9a5995a Compare January 25, 2024 06:28
@rohitwaghchaure rohitwaghchaure merged commit 822a5a8 into frappe:version-14-hotfix Jan 25, 2024
10 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.61.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants