Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent Return Invoices(Credit/Debit Note) from using a different account #39559

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jan 25, 2024

When Credit Note/Debit Note is made from a parent invoice, prevent it from using a different credit_to or debit_to account to that of parent. This validation only applies, if return_against is set.

@ruthra-kumar ruthra-kumar force-pushed the prevent_cr_note_with_different_account_to_sales_invoice branch from 00abdb0 to bdca718 Compare January 30, 2024 05:09
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (079cd30) 60.19% compared to head (bdca718) 60.20%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39559      +/-   ##
===========================================
+ Coverage    60.19%   60.20%   +0.01%     
===========================================
  Files          757      757              
  Lines        70799    70811      +12     
===========================================
+ Hits         42620    42635      +15     
+ Misses       28179    28176       -3     
Files Coverage Δ
erpnext/controllers/accounts_controller.py 85.49% <100.00%> (+0.06%) ⬆️
erpnext/controllers/status_updater.py 88.42% <ø> (ø)
erpnext/controllers/subcontracting_controller.py 89.43% <100.00%> (+0.05%) ⬆️
erpnext/manufacturing/doctype/bom/bom.py 73.35% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 2e5d716 into frappe:develop Jan 30, 2024
14 checks passed
ruthra-kumar added a commit that referenced this pull request Jan 30, 2024
…-39559

fix: prevent Return Invoices(Credit/Debit Note) from using a different account  (backport #39559)
ruthra-kumar added a commit that referenced this pull request Jan 30, 2024
…-39559

fix: prevent Return Invoices(Credit/Debit Note) from using a different account  (backport #39559)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant