-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use receipt amount for reverse provisional entry #39584
fix: use receipt amount for reverse provisional entry #39584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #39584 +/- ##
============================================
- Coverage 60.16% 0 -60.17%
============================================
Files 757 0 -757
Lines 70726 0 -70726
============================================
- Hits 42552 0 -42552
+ Misses 28174 0 -28174 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be cases where a single service row item is partially invoiced. For eg: Lets say 10 hours of a particular service is received but only 5 hours is invoiced in a particular Purchase Invoice. In that case you'll have to reverse the purchase invoice amount only.
f65a410
to
c5770f2
Compare
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
…-39584 fix: use receipt amount for reverse provisional entry (backport #39584)
…-39584 fix: use receipt amount for reverse provisional entry (backport #39584)
Bug
When Provisional Accounting is enabled for Non-stock Items and a Purchase Receipt is created with an amount eg - ₹2000, the GL entry posted against the provisional account is for ₹2000. If a Purchase Invoice is created with the same amount a reverse entry is made against the mentioned GL entry. However, if a Purchase Invoice is created with a different amount eg - ₹2500, the reverse entry is still made for ₹2000 in the provisional account. This leads to a remaining balance of ₹500 even after the reversal.
Solution
Use the Purchase Receipt amount for creating the reverse entry on submission of the Invoice.