Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Do proper currency conversion on Future Payments column in AR/AP report #39591

Merged

Conversation

ruthra-kumar
Copy link
Member

AR/AP was reporting incorrect amount in future payment columns on foreign currency payments. Fixing in this PR.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4f1e729) 60.14% compared to head (7b37389) 60.16%.
Report is 35 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39591      +/-   ##
===========================================
+ Coverage    60.14%   60.16%   +0.01%     
===========================================
  Files          757      757              
  Lines        70696    70733      +37     
===========================================
+ Hits         42523    42557      +34     
- Misses       28173    28176       +3     
Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 89.50% <76.92%> (-0.24%) ⬇️

... and 13 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 5be868c into frappe:develop Jan 27, 2024
15 checks passed
ruthra-kumar added a commit that referenced this pull request Jan 27, 2024
…-39591

refactor: Do proper currency conversion on Future Payments column in AR/AP report (backport #39591)
ruthra-kumar added a commit that referenced this pull request Jan 27, 2024
…-39591

refactor: Do proper currency conversion on Future Payments column in AR/AP report (backport #39591)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant