Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect landed cost voucher amount #39684

Conversation

rohitwaghchaure
Copy link
Collaborator

  • Create two purchase receipts, one will have 2 items and another one has single item.
  • Create landed cost voucher and pull both above purchase receipts
  • Pull all 3 items
  • Set "Distribute Charges Based On" as "Distribute Manually"
  • Add Applicable Charges with amount as 600
  • Set the Applicable Charges as 100, 100, 200 to all 3 items respectively.
  • Try to submit the landed cost voucher

You will get the below error
Screenshot 2024-02-01 at 11 38 00 AM

Solution

  1. If the "Distribute Charges Based On" set as "Distribute Manually" then don't allow user to add multiple Applicable Charges
  2. Don't Distribute Charges if the "Distribute Manually" option has set.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ebc8230) 60.09% compared to head (d78a1e7) 60.13%.
Report is 173 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #39684      +/-   ##
===========================================
+ Coverage    60.09%   60.13%   +0.04%     
===========================================
  Files          757      758       +1     
  Lines        70434    70965     +531     
===========================================
+ Hits         42325    42673     +348     
- Misses       28109    28292     +183     
Files Coverage Δ
...stock/doctype/purchase_receipt/purchase_receipt.py 73.03% <100.00%> (+0.21%) ⬆️
...doctype/landed_cost_voucher/landed_cost_voucher.py 80.00% <50.00%> (-0.40%) ⬇️
...tax_withholding_details/tax_withholding_details.py 81.14% <90.00%> (ø)

... and 47 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit d7e4a6b into frappe:develop Feb 5, 2024
15 checks passed
rohitwaghchaure added a commit that referenced this pull request Feb 5, 2024
…-39684

fix: incorrect landed cost voucher amount (backport #39684)
rohitwaghchaure added a commit that referenced this pull request Feb 5, 2024
…-39684

fix: incorrect landed cost voucher amount (backport #39684)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant