Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enforce unique GL Account for each 'Bank Account' #39694

Merged
merged 3 commits into from
Feb 6, 2024
Merged

refactor: enforce unique GL Account for each 'Bank Account' #39694

merged 3 commits into from
Feb 6, 2024

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Feb 2, 2024 •
edited
Loading

Validation to enforce separate General Ledger account for each Bank Account.
Screenshot 2024-02-02 at 5 45 43 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 2, 2024
@ruthra-kumar ruthra-kumar changed the title refactor: ensure unique accounts for each Bank Account's refactor: ensure unique accounts for each Bank Accounts Feb 2, 2024
@ruthra-kumar ruthra-kumar changed the title refactor: ensure unique accounts for each Bank Accounts refactor: ensure unique accounts for each 'Bank Account's Feb 2, 2024
@ruthra-kumar ruthra-kumar force-pushed the enforce_separate_account_for_each_bank_account branch from a5b1f84 to a882b98 Compare February 2, 2024 14:57
@ruthra-kumar ruthra-kumar linked an issue Feb 2, 2024 that may be closed by this pull request
Subject-Bank account is missing in GL entry,Bank account wise balance calculation is not happening. #39460
Closed
@ruthra-kumar ruthra-kumar force-pushed the enforce_separate_account_for_each_bank_account branch from a882b98 to 69e32ca Compare February 3, 2024 06:05
@ruthra-kumar ruthra-kumar force-pushed the enforce_separate_account_for_each_bank_account branch from 69e32ca to 322cdba Compare February 3, 2024 06:42
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (079cd30) 60.19% compared to head (322cdba) 60.12%.
Report is 44 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #39694      +/-   ##
===========================================
- Coverage    60.19%   60.12%   -0.07%     
===========================================
  Files          757      758       +1     
  Lines        70799    70970     +171     
===========================================
+ Hits         42620    42674      +54     
- Misses       28179    28296     +117
Files Coverage Δ
erpnext/controllers/status_updater.py 88.42% <ø> (ø)
erpnext/controllers/subcontracting_controller.py 89.43% <100.00%> (+0.05%) ⬆️
erpnext/manufacturing/doctype/bom/bom.py 73.35% <100.00%> (+0.03%) ⬆️
...next/accounts/doctype/bank_account/bank_account.py 57.97% <83.33%> (+2.41%) ⬆️

... and 18 files with indirect coverage changes

@ruthra-kumar ruthra-kumar changed the title refactor: ensure unique accounts for each 'Bank Account's refactor: ensure unique GL Account for each 'Bank Account' Feb 3, 2024
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Feb 3, 2024
@ruthra-kumar ruthra-kumar changed the title refactor: ensure unique GL Account for each 'Bank Account' refactor: enforce unique GL Account for each 'Bank Account' Feb 4, 2024
@ruthra-kumar ruthra-kumar merged commit 2e509f6 into frappe:develop Feb 6, 2024
17 checks passed
This was referenced Feb 6, 2024
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Feb 6, 2024
@ruthra-kumar
Merge pull request #39750 from frappe/mergify/bp/version-14-hotfix/pr…
ae4c907 
…-39694

refactor: enforce unique GL Account for each 'Bank Account' (backport #39694)
ruthra-kumar added a commit that referenced this pull request Feb 6, 2024
@ruthra-kumar
Merge pull request #39751 from frappe/mergify/bp/version-15-hotfix/pr…
47c2bd7 
…-39694

refactor: enforce unique GL Account for each 'Bank Account' (backport #39694)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subject-Bank account is missing in GL entry,Bank account wise balance calculation is not happening.
1 participant
@ruthra-kumar