Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancelling cr/dr notes should update the linked Invoice status #39783

Merged
merged 4 commits into from
Feb 7, 2024
Merged

fix: cancelling cr/dr notes should update the linked Invoice status #39783

merged 4 commits into from
Feb 7, 2024

Conversation

ruthra-kumar
Copy link
Member

  1. Make Sales Invoice
  2. Make Credit Note(Sales Return) againt [1]
  3. Reconcile them using Payment Reconciliation tool
  4. Sales Invoice will have 'Credit Note Issued' status
  5. Now, cancel Credit Note from [2]

Sales Invoice has incorrect status - 'Paid'. It should've been 'Unpaid', if no other Payments or Journals are allocated.

@ruthra-kumar ruthra-kumar merged commit 22a187c into frappe:develop Feb 7, 2024
13 checks passed
This was referenced Feb 7, 2024
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Feb 8, 2024
@ruthra-kumar
Merge pull request #39799 from frappe/mergify/bp/version-15-hotfix/pr…
0bde22f 
…-39783

fix: cancelling cr/dr notes should update the linked Invoice status (backport #39783)
ruthra-kumar added a commit that referenced this pull request Feb 8, 2024
@ruthra-kumar
Merge pull request #39798 from frappe/mergify/bp/version-14-hotfix/pr…
28b0e98 
…-39783

fix: cancelling cr/dr notes should update the linked Invoice status (backport #39783)
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 8, 2024 •
edited
Loading

backport version-14

✅ Backports have been created

@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-15

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 8, 2024 •
edited
Loading

backport version-15

✅ Backports have been created

This was referenced Feb 8, 2024
Merged
Merged
ruthra-kumar added a commit that referenced this pull request Feb 8, 2024
@ruthra-kumar
Merge pull request #39803 from frappe/mergify/bp/version-15/pr-39783
db4efd3 
fix: cancelling cr/dr notes should update the linked Invoice status (backport #39783)
ruthra-kumar added a commit that referenced this pull request Feb 8, 2024
@ruthra-kumar
Merge pull request #39802 from frappe/mergify/bp/version-14/pr-39783
e452e42 
fix: cancelling cr/dr notes should update the linked Invoice status (backport #39783)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
accounts backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruthra-kumar