fix: Handling circular linking while cancelling asset capitalization #39814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nabinhait
commented
Feb 8, 2024
nabinhait
commented
- While cancelling asset capitalization, the system was trying to cancel linked assent movement twice.
- On cancellation, target asset should be deleted if it is in the draft and created via capitalization
- Restore depreciation schedule of consumed asset on cancellation of capitalization
nabinhait
force-pushed
the
asset-capitalization-cancellation
branch
from
c5e89eb to
f2d094d
Compare
|
🎉 This PR is included in version 14.62.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
barredterra
reviewed
Feb 15, 2024
| @@ -77,15 +77,17 @@ def on_cancel(self): | |||
| "Stock Ledger Entry", | |||
| "Repost Item Valuation", | |||
| "Asset", | |||
| "Asset Movement" | |||
There was a problem hiding this comment.
Theres a comma missing here, as indicated by the linter failure on this PR. After merging without fixing this, the linter fails for all other PRs 😢 .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.