refactor: run qb directly instead of converting to sql #40299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
added a commit
that referenced
this pull request
Mar 11, 2024
…-40299 refactor: run qb directly instead of converting to sql (backport #40299)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Bank Reconciliation, the queries that fetch the matching vouchers from Payment Entry, Journal Entry and others is built in query builder and then converted to raw sql and passed to
frappe.db.sql. This unwanted conversion causes issues with escaping special characters in 'reference_no' field. Now, the query will be run directly as query builder object.