Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Supplier Quotation Comparison): group by options #40546

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Mar 19, 2024

We should only translate the labels, not the values, since the backend does handle translated select options.

@barredterra barredterra merged commit 815df8e into frappe:develop Mar 19, 2024
13 checks passed
@barredterra barredterra deleted the fix-group-by branch March 19, 2024 11:50
barredterra added a commit that referenced this pull request Mar 19, 2024
…-40546

fix(Supplier Quotation Comparison): group by options (backport #40546)
barredterra added a commit that referenced this pull request Mar 19, 2024
…-40546

fix(Supplier Quotation Comparison): group by options (backport #40546)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant